Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Слот и небольшая система для носков. Включая 31 новый вид их расцветки. #241

Merged
merged 20 commits into from
Sep 16, 2023

Conversation

ITamiokiI
Copy link

@ITamiokiI ITamiokiI commented Sep 11, 2023

О запросе слияния

Добавляет отдельный слот для носков, и 31 разновидность расцветок носков, включая по 2-3 вида их длинны для каждой расцветки(В общей сумме 85 новых носков). Все носки добавлены в Шкафы отделов, Локеты глав, а так же в экипировку всех должностей. Вид носков может изменяться от выбора одежды (Юбка-Комбинезон/Комбинезон).

Почему / Баланс

В игре имелись носки, но их слой отображения был сломан, отображаясь по верх юбки-комбинезона. Я решил исправить данную проблему, добавив под носки отдельный слот, имеющий свой слой. В добавок, решил разнообразить игру новыми видами носков, и небольшими фишками что с ними связаны.

Медиа

image

Чейнджлог
🆑 Tamioki

  • remove: Удалена старая система носков.
  • add: Добавлено 31 новый вид раскраса носков, не включая в счёт по 2-3 вариаций длинны каждого из раскрасов.
  • add: Добавлен новый тип слота одежды под носки.

@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link

@Mr0maks Mr0maks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вообще ещё одно замечание: Для глав предметы можно убрать в их специальные мешки для вещей.

Resources/Prototypes/Catalog/Fills/Lockers/heads.yml Outdated Show resolved Hide resolved
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link

github-actions bot commented Sep 16, 2023

RSI Diff Bot; head commit 0b652a5 merging into 558ca9c
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Clothing/Under/Socks/bee.rsi

State Old New Status
equipped-FEET Removed
icon Removed

Resources/Textures/Clothing/Under/Socks/ace_knee.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/ace_norm.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/ace_thigh.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/azure_knee.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/azure_norm.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/azure_thigh.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/bee_knee.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/bee_norm.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/bee_thigh.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/black_knee.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/black_norm.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/black_thigh.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/blue_knee.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/blue_norm.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/blue_thigh.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/cap_knee.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/cap_norm.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/cap_thigh.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/centcom_knee.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/centcom_norm.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/centcom_thigh.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/creepy_knee.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/creepy_thigh.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/cyan_knee.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/cyan_norm.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/cyan_thigh.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/fishnet_full.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/fishnet_knee.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/fishnet_thigh.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/furr_knee.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/furr_norm.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/furr_thigh.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/green_knee.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/green_norm.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/green_thigh.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/grey_knee.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/grey_norm.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/grey_thigh.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/holyday_knee.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/holyday_thigh.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/homelander_knee.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/homelander_norm.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/homelander_thigh.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/hop_knee.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/hop_norm.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/hop_thigh.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/hos_knee.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/hos_norm.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/hos_thigh.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/hotpink_knee.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/hotpink_norm.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/hotpink_thigh.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/monochrome_knee.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/monochrome_norm.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/monochrome_thigh.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/orange_knee.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/orange_norm.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/orange_thigh.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/pantyhose.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/pink_knee.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/pink_norm.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/purple_knee.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/purple_norm.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/purple_thigh.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/rainbow_knee.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/rainbow_thigh.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/red_knee.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Resources/Textures/Clothing/Under/Socks/red_norm.rsi

State Old New Status
equipped-SOCKS Added
icon Added

Edit: diff updated after 0b652a5

Copy link
Member

@AruMoon AruMoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Уменьши вместимость всех носков. Максимальный лимит пусть будет 3
  • Добавь носки шахтёрам
  • Убрать не относящийся к ПР файл

@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@AruMoon AruMoon merged commit d994b53 into Workbench-Team:arumoon-server Sep 16, 2023
16 of 17 checks passed
@ITamiokiI ITamiokiI deleted the socks branch September 16, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants